test: add non-AQE DPP edge case coverage for native Parquet scans#4037
Merged
mbutrovich merged 1 commit intoapache:mainfrom Apr 23, 2026
Merged
test: add non-AQE DPP edge case coverage for native Parquet scans#4037mbutrovich merged 1 commit intoapache:mainfrom
mbutrovich merged 1 commit intoapache:mainfrom
Conversation
andygrove
approved these changes
Apr 23, 2026
Member
andygrove
left a comment
There was a problem hiding this comment.
Thanks for adding more tests @mbutrovich
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #4033. Improves test coverage for #4011.
Rationale for this change
While working on AQE DPP broadcast reuse for Iceberg (#4033), we identified several non-AQE DPP scenarios that #4011 supports but doesn't explicitly test: multiple broadcast joins, broadcast exchange fallback, empty DPP results, and dual partition filter resolution. Adding these tests strengthens confidence in #4011's implementation and documents edge cases for future work on V1 Parquet AQE DPP (#3510).
What changes are included in this PR?
Four new non-AQE DPP tests in
CometExecSuite:convertSubqueryBroadcastshandles multiple independent DPP filters.convertSubqueryBroadcastsencounters a SparkBroadcastExchangeExecand correctly skips conversion. Verifies correct results via Spark's standard subquery path.CometNativeScanExec.partitionFiltersandCometScanExec.partitionFilterscontain differentInSubqueryExecinstances. Both must be resolved for partition selection to work. Verifies correct results, which requires both filter sets to be resolved.How are these changes tested?
The PR is entirely tests. All four tests use
AQE=falseto exercise #4011's non-AQE DPP code paths (PlanDynamicPruningFilters,convertSubqueryBroadcasts,ReuseExchangeAndSubquery).