fix: add TimestampLTZ-as-NTZ correctness tests and compatibility docs#4220
Open
andygrove wants to merge 9 commits intoapache:mainfrom
Open
fix: add TimestampLTZ-as-NTZ correctness tests and compatibility docs#4220andygrove wants to merge 9 commits intoapache:mainfrom
andygrove wants to merge 9 commits intoapache:mainfrom
Conversation
Spark 3.x raises per SPARK-36182; Comet should match. Skip test for native_datafusion/auto scans until apache#4219 is fixed. On Spark 4.0+ (SPARK-47447), verify Comet matches Spark instead.
- Add ParquetInt96NtzCorrectnessSuite to pr_build workflows - Update SPARK-36182 ignore link from apache#3720 to apache#4219 in 3.4/3.5 diffs - Remove IgnoreCometNativeDataFusion from SPARK-47447 test in 4.0/4.1 diffs since Comet should match Spark 4 behavior
Remove IgnoreCometNativeDataFusion from SPARK-47447 test by applying diffs to Spark v4.0.2/v4.1.1, editing, and regenerating with git diff.
The issue is not specific to INT96; it applies to any TimestampLTZ column read as TimestampNTZ regardless of physical encoding.
Broaden scans.md to cover all LTZ encodings and add note about unsupported type conversions (apache#3720). Add known limitations to Spark 3.4/3.5 sections linking to the scan compat doc.
andygrove
changed the title
andygrove
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParquetTimestampLtzAsNtzSuitecovering all LTZ encodings (INT96, TIMESTAMP_MICROS, TIMESTAMP_MILLIS) read as TimestampNTZcheckSparkAnswerAndOperator(SPARK-47447)IgnoreCometNativeDataFusionfrom SPARK-47447 test (Comet should pass it)scans.md: LTZ→NTZ behavior and unsupported type conversions (native_datafusion: no error thrown for schema mismatch when reading Parquet with incompatible types #3720)spark-versions.md: known limitations for Spark 3.4 and 3.5Test plan
checkSparkAnswerAndOperatorCloses #4218
🤖 Generated with Claude Code