ci: use path allow list for iceberg workflow triggers#4407
Merged
Conversation
Switch the iceberg_spark_test.yml push and pull_request triggers from paths-ignore (deny list) to paths (allow list), so the workflow runs only when files that actually affect iceberg tests change. With a deny list, every new file type that should not trigger iceberg CI must be added explicitly. An allow list excludes everything by default, so unrelated changes such as dev/ scripts, release tooling, and golden-file regeneration no longer trigger iceberg CI. The allow list mirrors spark_sql_test.yml, scoped to dev/diffs/iceberg and the iceberg-specific workflow and setup action.
mbutrovich
approved these changes
May 22, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks @andygrove!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4406
Rationale for this change
The iceberg workflow currently uses
paths-ignore(a deny list) to decide when to run. With a deny list, every new file or directory that should not trigger iceberg CI must be added explicitly, and it is easy to forget. As a result, unrelated changes such asdev/scripts, release tooling, and golden-file regeneration still trigger the full iceberg test matrix.spark_sql_test.ymlalready uses apathsallow list for the same reason. This PR brings the iceberg workflow in line with that approach.What changes are included in this PR?
Switches the
pushandpull_requesttriggers iniceberg_spark_test.ymlfrompaths-ignoretopaths. The allow list covers the inputs that actually affect iceberg tests:commonandsparkmain sources and POMs (excludingGenerateDocs.scala)dev/diffs/iceberg/**, applied by thesetup-iceberg-builderactionpom.xmlandrust-toolchain.tomlChanges to
dev/scripts, docs, markdown, benchmarks, tests, andspark-integrationno longer trigger iceberg CI.The allow list mirrors
spark_sql_test.yml, scoped todev/diffs/icebergand the iceberg-specific workflow and setup action.How are these changes tested?
This is a CI configuration change. The workflow file passes
actionlint, which is enforced by thevalidate_workflows.ymlworkflow.