perf: cache CometDecodedVector validityBufferAddress#4435
Merged
Conversation
…it on every validityByteCache miss.
mbutrovich
changed the title
Contributor
Author
# Conflicts: # spark/src/main/java/org/apache/comet/vector/CometDelegateVector.java # spark/src/main/java/org/apache/comet/vector/CometPlainVector.java # spark/src/main/java/org/apache/comet/vector/CometSelectionVector.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4279.
Rationale for this change
CometDecodedVector.isNullAtalready caches the validity bitmap byte, but it re-resolvedvalueVector.getValidityBuffer().memoryAddress()on every byte-cache miss. The buffer address is stable for the vector's lifetime, so the lookup can be cached once.What changes are included in this PR?
validityBufferAddressin theCometDecodedVectorconstructor; drop the per-miss lookup inisNullAt.How are these changes tested?
New
TestCometPlainVector.testIsNullAtSequentialAcrossValidityBytesexercises sequentialisNullAtreads (forward and reverse) across multiple validity bytes with mixed null/non-null rows.Otherwise, existing tests.