test: add timestamp ntz array cast coverage#4589
Merged
Merged
Conversation
Add CometCastSuite coverage for casting Array(TimestampNTZ) to String and to supported Array element types. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4248.
Rationale for this change
Array(TimestampNTZ)cast behavior should have explicit coverage for casts toStringand to other supported array element types. The existing array cast coverage covered many primitive and temporal cases, but did not include TimestampNTZ array inputs.What changes are included in this PR?
CometCastSuitearray-to-string coverage to includeArray(TimestampNTZ).CometCastSuitearray-to-array cast matrix to include TimestampNTZ array inputs.Array(TimestampNTZ)toStringand toArray(String),Array(Date), andArray(Timestamp)across representative timezones.How are these changes tested?
./mvnw test -Pjdk17 -Dtest=none -Dsuites="org.apache.comet.CometCastSuite cast ArrayType to StringType"./mvnw test -Pjdk17 -Dtest=none -Dsuites="org.apache.comet.CometCastSuite cast ArrayType to ArrayType"