chore: drop Spark 3.4 support - #5358
Open
manuzhang wants to merge 2 commits into
Open
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
manuzhang
marked this pull request as ready for review
August 14, 2026 08:14
| value: | | ||
| org.apache.comet.exec.CometAggregateSuite | ||
| org.apache.comet.exec.CometExec3_4PlusSuite | ||
| org.apache.comet.exec.CometExecCompatibilitySuite |
Member
Author
There was a problem hiding this comment.
Yes, CometExecCompatibilitySuite is renamed from CometExec3_4PlusSuite and used by all supported Spark versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4329.
Rationale for this change
Spark 3.4 was deprecated in Comet 1.0.0 and is scheduled for removal in 1.1.0. Dropping it reduces the supported build/test matrix and removes compatibility paths that are no longer needed now that Spark 3.5 is the oldest supported release.
What changes are included in this PR?
How are these changes tested?
make format PROFILES=-Pspark-3.5./mvnw clean test-compile -DskipTests -Pspark-4.0./mvnw clean test-compile -DskipTests -Pspark-4.1./mvnw clean test-compile -DskipTests -Pspark-4.2CometTPCDSV1_4_PlanStabilitySuiteon Spark 3.5 (97 tests)CometTPCDSV2_7_PlanStabilitySuiteon Spark 3.5 (32 tests)git diff --checkvalidation