fix: propagate Arrow array copy errors - #5747
Open
rich7420 wants to merge 1 commit into
Open
Conversation
manuzhang
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5706.
Rationale for this change
copy_arrayturns Arrow offset overflow errors into panics even though its callers already returnResult. Propagate those errors instead.What changes are included in this PR?
Return
Result<ArrayRef, ArrowError>fromcopy_array, use?for both the array copy and dictionary-value copy, and forward the result directly from the two callers.How are these changes tested?
Four Rust tests cover array and dictionary-value offset overflow, sliced nullable deep copies, and dictionary copying/unpacking. Overlapping ListView ranges over a NullArray trigger overflow without a large allocation. Restoring the original
expectcalls in a temporary copy makes both overflow tests fail with a panic.Fork CI passed: 1,183 Rust tests passed, including all four new tests, with four skipped. The macOS scans job passed on rerun after an HDFS thread-cleanup crash reported in #4200.
Local crate/test compilation, Clippy, and formatting checks also passed.