chore(release): include staged Maven artifacts link in vote email template#92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The release vote email template generated by
dev/release/create-tarball.shcurrently lists the source tarball and changelog but does not point voters at the staged Maven artifacts. Reviewers need to be able to verify the JARs that will be promoted to Maven Central along with the source release, so the email should include a link to them on the Apache Nexus staging repository.What changes are included in this PR?
Add a
[4]reference tohttps://repository.apache.org/#nexus-search;quick~datafusion-javain the email template body and footnote so voters can locate the staged Maven artifacts.Are these changes tested?
Eyeballed the generated email body. The change is only to a string template emitted by a release script that runs interactively.
Are there any user-facing changes?
No.