Skip to content

Enable substrait feature to be built by default in CI, for nightlies … #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 1 commit into from
Dec 3, 2023
Merged

Enable substrait feature to be built by default in CI, for nightlies … #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Build Python package
run: maturin build --release --strip
run: maturin build --release --strip --features substrait

- name: List Windows wheels
if: matrix.os == 'windows-latest'
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Build Python package
run: maturin build --release --strip --target aarch64-apple-darwin
run: maturin build --release --strip --target aarch64-apple-darwin --features substrait
- name: List Mac wheels
run: find target/wheels/

Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/bld.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# under the License.
#

maturin build -vv -j %CPU_COUNT% --release --strip --manylinux off --interpreter=%PYTHON%
maturin build -vv -j %CPU_COUNT% --release --strip --features substrait --manylinux off --interpreter=%PYTHON%

FOR /F "delims=" %%i IN ('dir /s /b target\wheels\*.whl') DO set datafusion_wheel=%%i

Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ EOF
sed -i.bak 's,aarch64,arm64,g' $BUILD_PREFIX/venv/lib/platform-patch.py
fi

maturin build -vv -j "${CPU_COUNT}" --release --strip --manylinux off --interpreter="${PYTHON}" "${_xtra_maturin_args[@]}"
maturin build -vv -j "${CPU_COUNT}" --release --strip --features substrait --manylinux off --interpreter="${PYTHON}" "${_xtra_maturin_args[@]}"

"${PYTHON}" -m pip install $SRC_DIR/target/wheels/datafusion*.whl --no-deps -vv

Expand Down