UNLOAD, SET TBLPROPERTIES, SERDEPROPERTIES, EXECUTE USING, SET LOCATION, DELIMITED, EXTENDED / FORMATTED#1137
Closed
jonathanlehto wants to merge 6 commits intoapache:mainfrom
Closed
UNLOAD, SET TBLPROPERTIES, SERDEPROPERTIES, EXECUTE USING, SET LOCATION, DELIMITED, EXTENDED / FORMATTED#1137jonathanlehto wants to merge 6 commits intoapache:mainfrom
jonathanlehto wants to merge 6 commits intoapache:mainfrom
Conversation
9 tasks
Contributor
|
Hi @jonathanlehto -- thank you for the contribution and I apologize for the delay in reviews. If you could please split this PR into smaller ones for easier review I would be most appreciative -- it will be much easier for me to verify that each feature is properly tested and documented in smaller PRs rather than one large one |
Contributor
|
Marking as Draft to signify this PR is no longer waiting on review. Please mark it as ready for review when it is ready for another look. |
Contributor
Author
Contributor
Thank you very much 🙏 |
Contributor
Author
|
Most of the split pr's are in. This pr is no longer necessary as a reference, closing.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some updates, I tried to find references and included them below. I'm not all too familiar with this repo. so feedback would be appreciated.
If needed, I can look into breaking out these changes into separate PR's.
SET TBLPROPERTIES -- https://docs.databricks.com/en/sql/language-manual/sql-ref-syntax-ddl-tblproperties.html#set-tblproperties
Hive Delimited Properties -- https://spark.apache.org/docs/latest/sql-ref-syntax-hive-format.html
Hive SERDEPROPERTIES -- https://spark.apache.org/docs/3.0.1/sql-ref-syntax-ddl-create-table-hiveformat.html
Hive EXTENDED / FORMATTED -- https://docs.cloudera.com/cdw-runtime/cloud/materialized-view-commands/topics/hive_describe_materialized_view.html
Added support for DESC version of DESCRIBE
EXECUTE USING -- https://www.postgresql.org/docs/current/plpgsql-statements.html#PLPGSQL-STATEMENTS-EXECUTING-DYN
Unload -- https://docs.aws.amazon.com/redshift/latest/dg/r_UNLOAD.html
Athena only, should this be its own dialect?
Athena SET LOCATION -- https://docs.aws.amazon.com/athena/latest/ug/alter-table-set-location.html
Doesn't require SET, also may be Athena only
Included is a possible bugfix where supporting columns after partition could consume a query