Skip to content

Support EXECUTE ... USING for Postgres#1153

Merged
alamb merged 3 commits intoapache:mainfrom
jonathanlehto:execute_using
Mar 1, 2024
Merged

Support EXECUTE ... USING for Postgres#1153
alamb merged 3 commits intoapache:mainfrom
jonathanlehto:execute_using

Conversation

@jonathanlehto
Copy link
Copy Markdown
Contributor

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 29, 2024

Pull Request Test Coverage Report for Build 8102619743

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 29 of 30 (96.67%) changed or added relevant lines in 3 files are covered.
  • 397 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.1%) to 87.921%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_mysql.rs 6 99.54%
tests/sqlparser_clickhouse.rs 8 96.04%
src/tokenizer.rs 13 89.92%
src/dialect/mod.rs 14 80.53%
tests/sqlparser_postgres.rs 14 97.96%
src/parser/mod.rs 55 83.28%
src/ast/mod.rs 287 79.66%
Totals Coverage Status
Change from base Build 8096363009: 0.1%
Covered Lines: 20293
Relevant Lines: 23081

💛 - Coveralls

@alamb alamb changed the title adding execute_using Support EXECUTE ... USING for Postgres Mar 1, 2024
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonathanlehto , also breaking your changes up into smaller PRs has made it much easier to review. 🙏

parameters: vec![],
using: vec![
Expr::Cast {
expr: Box::new(Expr::Value(Value::Number("1337".parse().unwrap(), false))),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂 No problem, and thank you @alamb !

@alamb alamb merged commit 68b52a4 into apache:main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants