Describe the bug
On current main, the required full lint command fails in datafusion-sqllogictest when the postgres feature is enabled:
error: this argument is passed by value, but not consumed in the function body
--> datafusion/sqllogictest/src/engines/conversion.rs:99:37
|
99 | pub(crate) fn decimal_to_str(value: BigDecimal) -> String {
| ^^^^^^^^^^
= note: `-D clippy::needless-pass-by-value` implied by `-D warnings`
To Reproduce
cargo clippy --all-targets --all-features -- -D warnings
Expected behavior
The required workspace lint command succeeds. decimal_to_str only reads the BigDecimal, so it can accept a reference without changing output.
Additional context
Observed on commit 722cbf2e7 with the repository-pinned Rust 1.97 toolchain.
Describe the bug
On current
main, the required full lint command fails indatafusion-sqllogictestwhen thepostgresfeature is enabled:To Reproduce
Expected behavior
The required workspace lint command succeeds.
decimal_to_stronly reads theBigDecimal, so it can accept a reference without changing output.Additional context
Observed on commit
722cbf2e7with the repository-pinned Rust 1.97 toolchain.