Skip to content

Full workspace clippy fails in PostgreSQL decimal formatting #24974

Description

@osipovartem

Describe the bug

On current main, the required full lint command fails in datafusion-sqllogictest when the postgres feature is enabled:

error: this argument is passed by value, but not consumed in the function body
  --> datafusion/sqllogictest/src/engines/conversion.rs:99:37
   |
99 | pub(crate) fn decimal_to_str(value: BigDecimal) -> String {
   |                                     ^^^^^^^^^^
   = note: `-D clippy::needless-pass-by-value` implied by `-D warnings`

To Reproduce

cargo clippy --all-targets --all-features -- -D warnings

Expected behavior

The required workspace lint command succeeds. decimal_to_str only reads the BigDecimal, so it can accept a reference without changing output.

Additional context

Observed on commit 722cbf2e7 with the repository-pinned Rust 1.97 toolchain.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions