Support http s3 endpoints in datafusion-cli via CREATE EXTERNAL TABLE
#10080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/local_s3_again
branch
from
e96add1 to
733b593
Compare
alamb
commented
Apr 14, 2024
| secret_access_key, | ||
| session_token, | ||
| region, | ||
| endpoint, |
Contributor
Author
There was a problem hiding this comment.
One bug was that endpoint was not read here so I changes this to destructure the object so the compiler can check we don't forget fields
| } | ||
| _ => { | ||
| return internal_err!("Config value \"{}\" not found on AwsOptions", rem); | ||
| return config_err!("Config value \"{}\" not found on AwsOptions", rem); |
Contributor
Author
There was a problem hiding this comment.
drive by cleanup -- this is not an internal error
alamb
changed the title
This was referenced Apr 14, 2024
Contributor
Author
|
Whoops -- closed by accident |
alamb
commented
Apr 15, 2024
| pub region: Option<String>, | ||
| /// OSS or COS Endpoint | ||
| pub endpoint: Option<String>, | ||
| /// Allow HTTP (otherwise will always use https) |
Contributor
Author
There was a problem hiding this comment.
BTW I found the reworked configuration option system that @metesynnada added in #9382 really nice to work with ❤️
alamb
changed the title
CREATE EXTERNAL TABLE
andygrove
approved these changes
Apr 15, 2024
comphead
reviewed
Apr 15, 2024
| .await | ||
| .unwrap_err(); | ||
|
|
||
| assert_eq!(err.to_string(), "Invalid or Unsupported Configuration: Invalid endpoint: http://endpoint33. HTTP is not allowed for S3 endpoints. To allow HTTP, set 'aws.allow_http' to true"); |
Contributor
There was a problem hiding this comment.
should we also test with aws.allow_http enabled?
Contributor
Author
There was a problem hiding this comment.
I think I added that test below (demonstrate it doesn't error)
Comment on lines
+93
to
+97
| return config_err!( | ||
| "Invalid endpoint: {endpoint}. \ | ||
| HTTP is not allowed for S3 endpoints. \ | ||
| To allow HTTP, set 'aws.allow_http' to true" | ||
| ); |
phillipleblanc
approved these changes
Apr 15, 2024
Contributor
Author
|
Thanks everyone for the reviews ❤️ |
Omega359
pushed a commit
to Omega359/arrow-datafusion
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
closes #10072
Rationale for this change
See #10072
Basically I want to be able to do:
What changes are included in this PR?
Are these changes tested?
aws.endpointas a config optionAre there any user-facing changes?
Can use http endpoints now