Revert "remove derive(Copy) from Operator (#11132)"
#11341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b468ba7.
github-actions
bot
added
logical-expr
This was referenced Jul 8, 2024
andygrove
approved these changes
Jul 8, 2024
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b468ba7.
Which issue does this PR close?
Rationale for this change
We originally made this change in #11132 as we thought it was necessary for user defined sql extensions (#11207) but we eventually went with a different approach (specifically #11180 from @jayzhan211 )
Thus I think this change is unnecessary and since it is a breaking API change it will cause unnecessary issues on upgrade for users.
Let's revert it
What changes are included in this PR?
This reverts commit b468ba7 / #11132
Are these changes tested?
Yes, by CI / clippy
Are there any user-facing changes?
Revert what I think is an uncessary API change
cc @samuelcolvin and @andygrove