minor: remove unused is_sorted method from utils #14370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Jan 31, 2025
| } | ||
|
|
||
| /// Checks whether the given index sequence is monotonically non-decreasing. | ||
| pub fn is_sorted<T: Borrow<usize>>(sequence: impl IntoIterator<Item = T>) -> bool { |
Member
There was a problem hiding this comment.
@alamb @buraksenn Why are we removing a public API method without deprecating it first?
https://docs.rs/datafusion-common/latest/datafusion_common/utils/fn.is_sorted.html
Contributor
There was a problem hiding this comment.
Sorry -- that was a mistake. I can make a PR to put it back in w/ deprecated
Contributor
There was a problem hiding this comment.
alamb
added a commit
to alamb/datafusion
that referenced
this pull request
Jan 31, 2025
This reverts commit 29e9a1c.
alamb
added a commit
that referenced
this pull request
Jan 31, 2025
cj-zhukov
pushed a commit
to cj-zhukov/datafusion
that referenced
this pull request
Feb 3, 2025
* Revert "removed (apache#14370)" This reverts commit 29e9a1c. * Restore/Deprecate is_sorted * Update datafusion/common/src/utils/mod.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#.
Rationale for this change
While checking TODOs I saw this function since is_sorted is graduated from nightly and used in the repo this unused method can be deleted
What changes are included in this PR?
Deletion of unused function
Are these changes tested?
There is nothing to test since this is deletion of a unused util function
Are there any user-facing changes?
No