chore: enforce clippy::allow_attributes for physical crates

datafusion/physical-expr-adapter/src/lib.rs

@@ -21,6 +21,8 @@
     html_favicon_url = "https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg"
 )]
 #![cfg_attr(docsrs, feature(doc_cfg))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
 
 //! Physical expression schema adaptation utilities for DataFusion
 

datafusion/physical-expr-common/src/lib.rs

@@ -24,6 +24,8 @@
 // https://github.com/apache/datafusion/issues/11143
 #![deny(clippy::clone_on_ref_ptr)]
 #![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
 
 //! Physical Expr Common packages for [DataFusion]
 //! This package contains high level PhysicalExpr trait

datafusion/physical-optimizer/src/aggregate_statistics.rs

@@ -33,14 +33,15 @@ use crate::{OptimizerContext, PhysicalOptimizerRule};
 pub struct AggregateStatistics {}
 
 impl AggregateStatistics {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }
 }
 
 impl PhysicalOptimizerRule for AggregateStatistics {
     #[cfg_attr(feature = "recursive_protection", recursive::recursive)]
+    #[expect(clippy::allow_attributes)] // See https://github.com/apache/datafusion/issues/18881#issuecomment-3621545670
     #[allow(clippy::only_used_in_recursion)] // See https://github.com/rust-lang/rust-clippy/issues/14566
     fn optimize_plan(
         &self,

datafusion/physical-optimizer/src/coalesce_batches.rs

@@ -38,7 +38,7 @@ use datafusion_common::tree_node::{Transformed, TransformedResult, TreeNode};
 pub struct CoalesceBatches {}
 
 impl CoalesceBatches {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self::default()
     }

datafusion/physical-optimizer/src/combine_partial_final_agg.rs

@@ -39,7 +39,7 @@ use datafusion_physical_expr::{physical_exprs_equal, PhysicalExpr};
 pub struct CombinePartialFinalAggregate {}
 
 impl CombinePartialFinalAggregate {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/enforce_distribution.rs

@@ -184,7 +184,7 @@ use itertools::izip;
 pub struct EnforceDistribution {}
 
 impl EnforceDistribution {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/enforce_sorting/mod.rs

@@ -79,7 +79,7 @@ use itertools::izip;
 pub struct EnforceSorting {}
 
 impl EnforceSorting {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/filter_pushdown.rs

@@ -429,7 +429,6 @@ impl PhysicalOptimizerRule for FilterPushdown {
         )
     }
 
-    #[allow(deprecated)]
     fn optimize(
         &self,
         plan: Arc<dyn ExecutionPlan>,

datafusion/physical-optimizer/src/join_selection.rs

@@ -47,7 +47,7 @@ use std::sync::Arc;
 pub struct JoinSelection {}
 
 impl JoinSelection {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/lib.rs

@@ -24,6 +24,8 @@
 // https://github.com/apache/datafusion/issues/11143
 #![deny(clippy::clone_on_ref_ptr)]
 #![cfg_attr(test, allow(clippy::needless_pass_by_value))]
+// https://github.com/apache/datafusion/issues/18881
+#![deny(clippy::allow_attributes)]
 
 pub mod aggregate_statistics;
 pub mod coalesce_batches;

datafusion/physical-optimizer/src/limit_pushdown.rs

@@ -52,7 +52,7 @@ pub struct GlobalRequirements {
 }
 
 impl LimitPushdown {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/optimizer.rs

@@ -95,7 +95,7 @@ pub trait PhysicalOptimizerRule: Debug {
         context: &OptimizerContext,
     ) -> Result<Arc<dyn ExecutionPlan>> {
         // Default implementation: delegate to the old method for backwards compatibility
-        #[allow(deprecated)]
+        #[expect(deprecated)]
         self.optimize(plan, context.session_config().options())
     }
 

datafusion/physical-optimizer/src/projection_pushdown.rs

@@ -49,7 +49,7 @@ use datafusion_physical_plan::ExecutionPlan;
 pub struct ProjectionPushdown {}
 
 impl ProjectionPushdown {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/sanity_checker.rs

@@ -47,7 +47,7 @@ use itertools::izip;
 pub struct SanityCheckPlan {}
 
 impl SanityCheckPlan {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self {}
     }

datafusion/physical-optimizer/src/update_aggr_exprs.rs

@@ -48,7 +48,7 @@ use crate::{OptimizerContext, PhysicalOptimizerRule};
 pub struct OptimizeAggregateOrder {}
 
 impl OptimizeAggregateOrder {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new() -> Self {
         Self::default()
     }