feat: minor lambda perf improvements#21896
Merged
comphead merged 5 commits intoapache:mainfrom Apr 28, 2026
Merged
Conversation
github-actions
Bot
added
logical-expr
Contributor
Author
rluvaton
approved these changes
Apr 28, 2026
Comment on lines
+95
to
+97
| /// Cached value of [`HigherOrderUDF::clear_null_values`]. Avoids a virtual | ||
| /// call per non-lambda arg per batch. | ||
| clear_null_values: bool, |
Member
There was a problem hiding this comment.
Is it really expensive that it worth this?
Contributor
Author
There was a problem hiding this comment.
let me think. For current implementation it is not worthy, because trait just return true and LLVM can optimize this virtual call to just using a constant. however in future this method can be overridden and depending on implementation can potentially cause troubles. This micro optimization probably is too premature, you are right
Co-authored-by: Raz Luvaton <16746759+rluvaton@users.noreply.github.com>
Contributor
|
Thanks @comphead (my bad for not looking into this earlier, but I wouldn't have any comments anyway and would had approved as well) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Followup on #21679 (comment)
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?