ci: reintroduce code coverage reporting with cargo-llvm-cov#23336
Open
buraksenn wants to merge 3 commits into
Open
ci: reintroduce code coverage reporting with cargo-llvm-cov#23336buraksenn wants to merge 3 commits into
buraksenn wants to merge 3 commits into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23336 +/- ##
=======================================
Coverage ? 80.50%
=======================================
Files ? 1080
Lines ? 361256
Branches ? 361256
=======================================
Hits ? 290837
Misses ? 53122
Partials ? 17297 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
As expected it could not compare since there is no code coverage uploaded for main branch. After this PR merges it will be ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Failed to compile tests! Error: sql_integration: linking withccfailed: exit status: 1"#3678.Rationale for this change
Code coverage has been disabled since #3678. The reason was it failed because of sql_integration test binary. This PR reintroduces it
What changes are included in this PR?
Reintroduce code coverage
Are these changes tested?
I've been successfully make it work in my fork: buraksenn#345

I needed to add
CODECOV_TOKENas a secret variable to the fork.You can check #23336 (comment) comment of codecov for successful run
Are there any user-facing changes?
no