Skip to content

ci: reintroduce code coverage reporting with cargo-llvm-cov#23336

Open
buraksenn wants to merge 3 commits into
apache:mainfrom
buraksenn:reintroduce-code-coverage-with-llvm-cov
Open

ci: reintroduce code coverage reporting with cargo-llvm-cov#23336
buraksenn wants to merge 3 commits into
apache:mainfrom
buraksenn:reintroduce-code-coverage-with-llvm-cov

Conversation

@buraksenn

@buraksenn buraksenn commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Code coverage has been disabled since #3678. The reason was it failed because of sql_integration test binary. This PR reintroduces it

What changes are included in this PR?

Reintroduce code coverage

Are these changes tested?

I've been successfully make it work in my fork: buraksenn#345
image

I needed to add CODECOV_TOKEN as a secret variable to the fork.

You can check #23336 (comment) comment of codecov for successful run

Are there any user-facing changes?

no

@github-actions github-actions Bot added development-process Related to development process of DataFusion core Core DataFusion crate ffi Changes to the ffi crate labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion v54.0.0 (current)
       Built [ 105.892s] (current)
     Parsing datafusion v54.0.0 (current)
      Parsed [   0.034s] (current)
    Building datafusion v54.0.0 (baseline)
       Built [ 101.893s] (baseline)
     Parsing datafusion v54.0.0 (baseline)
      Parsed [   0.035s] (baseline)
    Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.570s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [ 211.212s] datafusion
    Building datafusion-ffi v54.0.0 (current)
       Built [  60.510s] (current)
     Parsing datafusion-ffi v54.0.0 (current)
      Parsed [   0.061s] (current)
    Building datafusion-ffi v54.0.0 (baseline)
       Built [  59.860s] (baseline)
     Parsing datafusion-ffi v54.0.0 (baseline)
      Parsed [   0.061s] (baseline)
    Checking datafusion-ffi v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.244s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/feature_missing.ron

Failed in:
  feature tarpaulin_include in the package's Cargo.toml

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [ 122.345s] datafusion-ffi

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Jul 6, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@215ebb8). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23336   +/-   ##
=======================================
  Coverage        ?   80.50%           
=======================================
  Files           ?     1080           
  Lines           ?   361256           
  Branches        ?   361256           
=======================================
  Hits            ?   290837           
  Misses          ?    53122           
  Partials        ?    17297           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@buraksenn

Copy link
Copy Markdown
Contributor Author

As expected it could not compare since there is no code coverage uploaded for main branch. After this PR merges it will be ready

@Jefffrey Jefffrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change core Core DataFusion crate development-process Related to development process of DataFusion ffi Changes to the ffi crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage jobs are failing on master: Failed to compile tests! Error: sql_integration: linking with cc failed: exit status: 1"

3 participants