Cap SortPreservingMerge statistics by fetch#23359
Open
discord9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
SortPreservingMergeExecsupportsfetch, but its statistics currently pass through child statistics unchanged. This can make cost-based optimizers overestimate top-k merge outputs. For example, aSortPreservingMergeExec(fetch=1)side can still look as large as its input toJoinSelection, causing hash join build/probe choices to miss the small top-k side.Other fetch-aware operators such as
SortExec,CoalescePartitionsExec, and limit execs already cap their statistics by fetch. This PR alignsSortPreservingMergeExecwith that behavior.What changes are included in this PR?
SortPreservingMergeExecstatistics withStatistics::with_fetch(self.fetch, 0, 1).fetch = Noneandskip = 0.0.0when input row count is unknown; use absent byte-size stats instead.JoinSelectionswapping an SPM(fetch=1) side to the hash join build side.Are these changes tested?
Yes.
cargo test -p datafusion-common test_with_fetchcargo test -p datafusion-physical-plan sort_preserving_mergecargo test -p datafusion join_selection --test core_integrationcargo check -p datafusion --test core_integrationcargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningsAre there any user-facing changes?
No user-facing API changes. This improves optimizer statistics for fetch-limited sort-preserving merge plans.