[physical-plan]: rename aggregate stream modules#23371
Closed
alamb wants to merge 4 commits into
Closed
Conversation
e5c7676 to
ea590eb
Compare
Contributor
Author
|
Closing in favor of a clean rename-only draft PR from codex/rename-aggregate-stream-modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Several aggregate stream implementations are stored in modules whose file names do not match the primary stream types they contain. This makes the aggregate module harder to scan because some stream files use the
_stream.rssuffix while others are named after older implementation details.What changes are included in this PR?
This PR renames aggregate stream modules so their filenames match the stream implementations more closely:
no_grouping.rs->aggregate_stream.rshash_aggregate.rs->hash_stream.rsrow_hash.rs->grouped_hash_stream.rstopk_stream.rs->grouped_topk_stream.rsIt also updates private module declarations, imports, and doc links/comments that referenced the old module names.
Are these changes tested?
No new tests are included because this is a module/file rename with no behavioral changes.
Validated with:
cargo fmt --all -- --checkcargo check -p datafusion-physical-planAre there any user-facing changes?
No. These modules are private implementation details of
datafusion-physical-plan.