Skip to content

[physical-plan]: rename aggregate stream modules#23371

Closed
alamb wants to merge 4 commits into
apache:mainfrom
alamb:split-aggr-simplify-ht-template
Closed

[physical-plan]: rename aggregate stream modules#23371
alamb wants to merge 4 commits into
apache:mainfrom
alamb:split-aggr-simplify-ht-template

Conversation

@alamb

@alamb alamb commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

Several aggregate stream implementations are stored in modules whose file names do not match the primary stream types they contain. This makes the aggregate module harder to scan because some stream files use the _stream.rs suffix while others are named after older implementation details.

What changes are included in this PR?

This PR renames aggregate stream modules so their filenames match the stream implementations more closely:

  • no_grouping.rs -> aggregate_stream.rs
  • hash_aggregate.rs -> hash_stream.rs
  • row_hash.rs -> grouped_hash_stream.rs
  • topk_stream.rs -> grouped_topk_stream.rs

It also updates private module declarations, imports, and doc links/comments that referenced the old module names.

Are these changes tested?

No new tests are included because this is a module/file rename with no behavioral changes.

Validated with:

  • cargo fmt --all -- --check
  • cargo check -p datafusion-physical-plan

Are there any user-facing changes?

No. These modules are private implementation details of datafusion-physical-plan.

@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Jul 7, 2026
@alamb alamb force-pushed the split-aggr-simplify-ht-template branch from e5c7676 to ea590eb Compare July 7, 2026 11:42
@alamb

alamb commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of a clean rename-only draft PR from codex/rename-aggregate-stream-modules.

@alamb alamb closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants