ci: Use install-action instead of cargo install to speed up CI#23477
Merged
Conversation
github-actions
Bot
added
the
development-process
2010YOUY01
marked this pull request as draft
July 11, 2026 13:41
Contributor
Author
|
The step of installing https://github.com/apache/datafusion/actions/runs/29175818974/job/86604744160 Other See https://github.com/taiki-e/install-action/blob/main/TOOLS.md |
2010YOUY01
marked this pull request as ready for review
July 12, 2026 02:09
comphead
approved these changes
Jul 12, 2026
comphead
left a comment
comphead
left a comment
Contributor
There was a problem hiding this comment.
Thanks @2010YOUY01 lets see this in practice, hope it would make easier with retries and https issues during download
alamb
approved these changes
Jul 13, 2026
Contributor
|
Thanks @2010YOUY01 and @comphead |
philippemnoel
pushed a commit
to paradedb/datafusion
that referenced
this pull request
Jul 17, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Follow-up to apache#23477. The original PR missed one instance; this PR applies the same change to that case. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
For CI dependencies installed with
cargo install, it's possible to useinstall-actioninstead for faster setup. (former compiles the binary, the latter directly download the release version) , each of them should get ~1min faster.What changes are included in this PR?
install-actioninstead ofcargo installfor existing CI jobsgrep cargo installfor all Github Action scripts)Are these changes tested?
Are there any user-facing changes?