Skip to content

Js/benchmark 4 dynamic filtering alternatives#23725

Closed
jayshrivastava wants to merge 2 commits into
apache:mainfrom
jayshrivastava:js/benchmark-4-dynamic-filtering-alternatives
Closed

Js/benchmark 4 dynamic filtering alternatives#23725
jayshrivastava wants to merge 2 commits into
apache:mainfrom
jayshrivastava:js/benchmark-4-dynamic-filtering-alternatives

Conversation

@jayshrivastava

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added sqllogictest SQL Logic Tests (.slt) common Related to common crate physical-plan Changes to the physical-plan crate labels Jul 20, 2026
@github-actions

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion-common v54.0.0 (current)
       Built [  33.816s] (current)
     Parsing datafusion-common v54.0.0 (current)
      Parsed [   0.064s] (current)
    Building datafusion-common v54.0.0 (baseline)
       Built [  33.197s] (baseline)
     Parsing datafusion-common v54.0.0 (baseline)
      Parsed [   0.064s] (baseline)
    Checking datafusion-common v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   1.108s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field OptimizerOptions.hash_join_dynamic_filter_partitioned_expr_style in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:1360

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  69.801s] datafusion-common
    Building datafusion-physical-plan v54.0.0 (current)
       Built [  35.868s] (current)
     Parsing datafusion-physical-plan v54.0.0 (current)
      Parsed [   0.148s] (current)
    Building datafusion-physical-plan v54.0.0 (baseline)
       Built [  35.924s] (baseline)
     Parsing datafusion-physical-plan v54.0.0 (baseline)
      Parsed [   0.150s] (baseline)
    Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   1.010s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [  74.745s] datafusion-physical-plan
    Building datafusion-sqllogictest v54.0.0 (current)
       Built [ 188.057s] (current)
     Parsing datafusion-sqllogictest v54.0.0 (current)
      Parsed [   0.024s] (current)
    Building datafusion-sqllogictest v54.0.0 (baseline)
       Built [ 188.127s] (baseline)
     Parsing datafusion-sqllogictest v54.0.0 (baseline)
      Parsed [   0.024s] (baseline)
    Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.111s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [ 379.278s] datafusion-sqllogictest

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Jul 20, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.43478% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.71%. Comparing base (ca02890) to head (cd0c836).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...physical-plan/src/joins/hash_join/shared_bounds.rs 90.68% 24 Missing and 18 partials ⚠️
benchmarks/src/hj.rs 0.00% 1 Missing ⚠️
...tafusion/physical-plan/src/joins/hash_join/exec.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23725      +/-   ##
==========================================
+ Coverage   80.66%   80.71%   +0.05%     
==========================================
  Files        1087     1089       +2     
  Lines      367409   368425    +1016     
  Branches   367409   368425    +1016     
==========================================
+ Hits       296365   297377    +1012     
+ Misses      53393    53333      -60     
- Partials    17651    17715      +64     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change common Related to common crate physical-plan Changes to the physical-plan crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants