Skip to content

[IGNORE] pass to everywhere that use arrow ipc reader the option to share or not share buffers#23753

Draft
rluvaton wants to merge 4 commits into
apache:mainfrom
rluvaton:test-ipc-not-sharing-buffers
Draft

[IGNORE] pass to everywhere that use arrow ipc reader the option to share or not share buffers#23753
rluvaton wants to merge 4 commits into
apache:mainfrom
rluvaton:test-ipc-not-sharing-buffers

Conversation

@rluvaton

Copy link
Copy Markdown
Member

TODO - fill this

Which issue does this PR close?

  • Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@rluvaton

Copy link
Copy Markdown
Member Author

run benchmarks

@github-actions github-actions Bot added common Related to common crate execution Related to the execution crate datasource Changes to the datasource crate physical-plan Changes to the physical-plan crate labels Jul 21, 2026
@adriangbot

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5032740491-1203-j8946 6.12.85+ #1 SMP Mon May 11 08:17:35 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing test-ipc-not-sharing-buffers (71931ff) to ed22a4a (merge-base) diff using: clickbench_partitioned
Results will be posted here when complete


File an issue against this benchmark runner

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion-common v54.0.0 (current)
       Built [  36.972s] (current)
     Parsing datafusion-common v54.0.0 (current)
      Parsed [   0.061s] (current)
    Building datafusion-common v54.0.0 (baseline)
       Built [  34.710s] (baseline)
     Parsing datafusion-common v54.0.0 (baseline)
      Parsed [   0.061s] (baseline)
    Checking datafusion-common v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.677s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field ExecutionOptions.ipc_buffer_allocation_strategy in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:791

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  74.649s] datafusion-common
    Building datafusion-datasource-arrow v54.0.0 (current)
       Built [  39.747s] (current)
     Parsing datafusion-datasource-arrow v54.0.0 (current)
      Parsed [   0.011s] (current)
    Building datafusion-datasource-arrow v54.0.0 (baseline)
       Built [  38.367s] (baseline)
     Parsing datafusion-datasource-arrow v54.0.0 (baseline)
      Parsed [   0.012s] (baseline)
    Checking datafusion-datasource-arrow v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.073s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [  80.097s] datafusion-datasource-arrow
    Building datafusion-execution v54.0.0 (current)
       Built [  30.391s] (current)
     Parsing datafusion-execution v54.0.0 (current)
      Parsed [   0.025s] (current)
    Building datafusion-execution v54.0.0 (baseline)
       Built [  31.168s] (baseline)
     Parsing datafusion-execution v54.0.0 (baseline)
      Parsed [   0.026s] (baseline)
    Checking datafusion-execution v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.224s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [  63.177s] datafusion-execution
    Building datafusion-physical-plan v54.0.0 (current)
       Built [  38.514s] (current)
     Parsing datafusion-physical-plan v54.0.0 (current)
      Parsed [   0.141s] (current)
    Building datafusion-physical-plan v54.0.0 (baseline)
       Built [  38.282s] (baseline)
     Parsing datafusion-physical-plan v54.0.0 (baseline)
      Parsed [   0.139s] (baseline)
    Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch)
     Checked [   0.633s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [  79.139s] datafusion-physical-plan

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Jul 21, 2026
@adriangbot

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5032740491-1204-jpmgb 6.12.85+ #1 SMP Mon May 11 08:17:35 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing test-ipc-not-sharing-buffers (71931ff) to ed22a4a (merge-base) diff using: tpcds
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5032740491-1205-ptp2r 6.12.85+ #1 SMP Mon May 11 08:17:35 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing test-ipc-not-sharing-buffers (71931ff) to ed22a4a (merge-base) diff using: tpch
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

Benchmark for this request failed.

Last 20 lines of output:

Click to expand
    --> datafusion/common/src/config.rs:3831:27
     |
3831 |     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
     |                           ^^^^^^^^^^^^^^^^^^
     |
help: remove the unnecessary path segments
     |
3831 -     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
3831 +     fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
     |

error[E0119]: conflicting implementations of trait `std::default::Default` for type `BufferAllocationStrategyWrapper`
   --> datafusion/common/src/config.rs:589:47
    |
589 | #[derive(Default, Clone, Copy, PartialEq, Eq, Default)]
    |          ------- first implementation here    ^^^^^^^ conflicting implementation for `BufferAllocationStrategyWrapper`

For more information about this error, try `rustc --explain E0119`.
warning: `datafusion-common` (lib) generated 2 warnings
error: could not compile `datafusion-common` (lib) due to 10 previous errors; 2 warnings emitted

File an issue against this benchmark runner

2 similar comments
@adriangbot

Copy link
Copy Markdown

Benchmark for this request failed.

Last 20 lines of output:

Click to expand
    --> datafusion/common/src/config.rs:3831:27
     |
3831 |     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
     |                           ^^^^^^^^^^^^^^^^^^
     |
help: remove the unnecessary path segments
     |
3831 -     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
3831 +     fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
     |

error[E0119]: conflicting implementations of trait `std::default::Default` for type `BufferAllocationStrategyWrapper`
   --> datafusion/common/src/config.rs:589:47
    |
589 | #[derive(Default, Clone, Copy, PartialEq, Eq, Default)]
    |          ------- first implementation here    ^^^^^^^ conflicting implementation for `BufferAllocationStrategyWrapper`

For more information about this error, try `rustc --explain E0119`.
warning: `datafusion-common` (lib) generated 2 warnings
error: could not compile `datafusion-common` (lib) due to 10 previous errors; 2 warnings emitted

File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

Benchmark for this request failed.

Last 20 lines of output:

Click to expand
    --> datafusion/common/src/config.rs:3831:27
     |
3831 |     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
     |                           ^^^^^^^^^^^^^^^^^^
     |
help: remove the unnecessary path segments
     |
3831 -     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
3831 +     fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
     |

error[E0119]: conflicting implementations of trait `std::default::Default` for type `BufferAllocationStrategyWrapper`
   --> datafusion/common/src/config.rs:589:47
    |
589 | #[derive(Default, Clone, Copy, PartialEq, Eq, Default)]
    |          ------- first implementation here    ^^^^^^^ conflicting implementation for `BufferAllocationStrategyWrapper`

For more information about this error, try `rustc --explain E0119`.
warning: `datafusion-common` (lib) generated 2 warnings
error: could not compile `datafusion-common` (lib) due to 10 previous errors; 2 warnings emitted

File an issue against this benchmark runner

@rluvaton

Copy link
Copy Markdown
Member Author

run benchmark external_aggr tpch10 wide_schema smj

changed:
  env:
    DATAFUSION_EXECUTION_IPC_BUFFER_ALLOCATION_STRATEGY: owned

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5032974437-1206-sfw2z 6.12.85+ #1 SMP Mon May 11 08:17:35 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing test-ipc-not-sharing-buffers (5046ad2) to ed22a4a (merge-base) diff using: external_aggr
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5032974437-1209-q2zmh 6.12.85+ #1 SMP Mon May 11 08:17:35 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing test-ipc-not-sharing-buffers (5046ad2) to ed22a4a (merge-base) diff using: smj
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5032974437-1208-jtlkw 6.12.85+ #1 SMP Mon May 11 08:17:35 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing test-ipc-not-sharing-buffers (5046ad2) to ed22a4a (merge-base) diff using: wide_schema
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c5032974437-1207-wjrnj 6.12.85+ #1 SMP Mon May 11 08:17:35 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing test-ipc-not-sharing-buffers (5046ad2) to ed22a4a (merge-base) diff using: tpch10
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details

Comparing HEAD and test-ipc-not-sharing-buffers
--------------------
Benchmark smj.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃                                 HEAD ┃         test-ipc-not-sharing-buffers ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1  │          8.30 / 8.60 ±0.22 / 8.95 ms │          8.43 / 8.74 ±0.24 / 9.14 ms │     no change │
│ QQuery 2  │    161.50 / 164.17 ±1.76 / 166.82 ms │    161.10 / 165.11 ±2.15 / 167.43 ms │     no change │
│ QQuery 3  │    104.71 / 106.58 ±2.52 / 111.58 ms │    103.22 / 105.58 ±1.65 / 107.84 ms │     no change │
│ QQuery 4  │       28.01 / 28.06 ±0.05 / 28.15 ms │       28.29 / 28.43 ±0.10 / 28.56 ms │     no change │
│ QQuery 5  │       20.57 / 20.73 ±0.16 / 21.03 ms │       20.70 / 20.84 ±0.08 / 20.93 ms │     no change │
│ QQuery 6  │    159.08 / 160.76 ±1.66 / 163.71 ms │    159.55 / 160.20 ±0.68 / 161.29 ms │     no change │
│ QQuery 7  │    196.80 / 198.70 ±1.74 / 201.77 ms │   200.09 / 213.96 ±27.26 / 268.48 ms │  1.08x slower │
│ QQuery 8  │       18.85 / 19.09 ±0.18 / 19.37 ms │       18.68 / 19.52 ±0.95 / 21.37 ms │     no change │
│ QQuery 9  │    205.97 / 207.67 ±1.81 / 210.64 ms │    206.65 / 208.40 ±1.50 / 210.79 ms │     no change │
│ QQuery 10 │       57.82 / 58.10 ±0.23 / 58.46 ms │       57.76 / 59.01 ±2.27 / 63.54 ms │     no change │
│ QQuery 11 │       27.30 / 30.02 ±5.08 / 40.17 ms │       27.32 / 29.36 ±3.60 / 36.53 ms │     no change │
│ QQuery 12 │       67.99 / 70.44 ±2.04 / 73.93 ms │       62.88 / 69.93 ±4.02 / 74.90 ms │     no change │
│ QQuery 13 │    105.51 / 109.68 ±2.37 / 112.12 ms │    104.97 / 108.56 ±3.05 / 113.82 ms │     no change │
│ QQuery 14 │       58.46 / 64.29 ±9.65 / 83.53 ms │       57.84 / 58.25 ±0.45 / 59.13 ms │ +1.10x faster │
│ QQuery 15 │       58.93 / 59.10 ±0.15 / 59.28 ms │       57.77 / 57.92 ±0.12 / 58.03 ms │     no change │
│ QQuery 16 │       11.79 / 11.85 ±0.07 / 11.98 ms │       11.40 / 11.60 ±0.10 / 11.71 ms │     no change │
│ QQuery 17 │    146.68 / 150.19 ±6.21 / 162.58 ms │    146.66 / 150.31 ±5.21 / 160.64 ms │     no change │
│ QQuery 18 │    111.25 / 111.73 ±0.30 / 112.18 ms │    111.16 / 112.11 ±0.69 / 113.31 ms │     no change │
│ QQuery 19 │    292.06 / 298.67 ±7.06 / 311.30 ms │    288.87 / 296.96 ±6.66 / 304.87 ms │     no change │
│ QQuery 20 │ 1265.10 / 1279.63 ±9.72 / 1290.39 ms │ 1266.24 / 1271.03 ±3.90 / 1276.72 ms │     no change │
│ QQuery 21 │      93.56 / 97.55 ±5.34 / 108.09 ms │     95.43 / 100.52 ±8.45 / 117.39 ms │     no change │
│ QQuery 22 │    100.71 / 101.74 ±0.81 / 102.92 ms │     99.95 / 103.98 ±2.91 / 108.91 ms │     no change │
│ QQuery 23 │    106.88 / 110.50 ±2.67 / 114.53 ms │    110.80 / 113.24 ±2.41 / 116.96 ms │     no change │
│ QQuery 24 │       27.01 / 27.10 ±0.09 / 27.25 ms │       27.28 / 27.45 ±0.14 / 27.70 ms │     no change │
│ QQuery 25 │       68.83 / 71.02 ±2.79 / 76.41 ms │       68.63 / 72.01 ±3.09 / 77.18 ms │     no change │
│ QQuery 26 │    106.74 / 113.75 ±6.34 / 122.74 ms │    97.15 / 111.55 ±11.01 / 130.90 ms │     no change │
└───────────┴──────────────────────────────────────┴──────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                           ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                           │ 3679.72ms │
│ Total Time (test-ipc-not-sharing-buffers)   │ 3684.56ms │
│ Average Time (HEAD)                         │  141.53ms │
│ Average Time (test-ipc-not-sharing-buffers) │  141.71ms │
│ Queries Faster                              │         1 │
│ Queries Slower                              │         1 │
│ Queries with No Change                      │        24 │
│ Queries with Failure                        │         0 │
└─────────────────────────────────────────────┴───────────┘

Resource Usage

smj — base (merge-base)

Metric Value
Wall time 20.0s
Peak memory 1.2 GiB
Avg memory 456.1 MiB
CPU user 157.4s
CPU sys 3.3s
Peak spill 0 B

smj — branch

Metric Value
Wall time 20.0s
Peak memory 1.2 GiB
Avg memory 452.1 MiB
CPU user 156.7s
CPU sys 3.4s
Peak spill 0 B

File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details

Comparing HEAD and test-ipc-not-sharing-buffers
--------------------
Benchmark tpch_sf10.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query     ┃                               HEAD ┃       test-ipc-not-sharing-buffers ┃    Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 1  │  310.70 / 312.75 ±1.54 / 315.28 ms │  313.06 / 315.42 ±1.37 / 317.24 ms │ no change │
│ QQuery 2  │  104.18 / 107.43 ±3.56 / 112.10 ms │  105.29 / 106.29 ±1.02 / 108.01 ms │ no change │
│ QQuery 3  │  238.62 / 240.20 ±1.66 / 243.11 ms │  238.55 / 242.47 ±3.42 / 248.11 ms │ no change │
│ QQuery 4  │  114.00 / 116.41 ±2.61 / 120.58 ms │  113.42 / 116.52 ±1.72 / 117.93 ms │ no change │
│ QQuery 5  │  361.18 / 366.36 ±7.47 / 381.13 ms │  354.21 / 368.09 ±8.42 / 377.29 ms │ no change │
│ QQuery 6  │  126.36 / 127.94 ±2.17 / 132.21 ms │  124.67 / 127.32 ±3.34 / 133.88 ms │ no change │
│ QQuery 7  │  471.26 / 478.46 ±7.89 / 493.84 ms │  467.28 / 476.98 ±5.12 / 482.18 ms │ no change │
│ QQuery 8  │  387.25 / 396.52 ±7.03 / 407.87 ms │ 381.95 / 399.19 ±18.08 / 434.07 ms │ no change │
│ QQuery 9  │  564.98 / 572.35 ±3.73 / 575.23 ms │  560.02 / 572.63 ±9.81 / 589.66 ms │ no change │
│ QQuery 10 │  305.91 / 310.13 ±3.60 / 315.23 ms │ 303.89 / 316.31 ±20.13 / 356.20 ms │ no change │
│ QQuery 11 │     86.87 / 89.95 ±2.66 / 93.75 ms │     85.96 / 88.28 ±1.69 / 90.24 ms │ no change │
│ QQuery 12 │  176.36 / 184.13 ±8.70 / 199.15 ms │  177.76 / 183.55 ±5.86 / 194.10 ms │ no change │
│ QQuery 13 │  292.17 / 303.92 ±7.85 / 311.82 ms │  286.91 / 296.15 ±6.88 / 303.98 ms │ no change │
│ QQuery 14 │  173.27 / 176.08 ±4.45 / 184.94 ms │  174.77 / 176.73 ±2.37 / 181.39 ms │ no change │
│ QQuery 15 │  305.07 / 310.44 ±3.09 / 314.27 ms │  307.56 / 312.18 ±3.78 / 318.35 ms │ no change │
│ QQuery 16 │     65.86 / 68.38 ±2.88 / 73.32 ms │     66.37 / 68.67 ±2.13 / 71.27 ms │ no change │
│ QQuery 17 │ 634.36 / 645.28 ±11.85 / 667.51 ms │ 646.93 / 658.20 ±12.05 / 679.37 ms │ no change │
│ QQuery 18 │ 677.98 / 706.31 ±17.99 / 726.19 ms │ 703.66 / 717.94 ±14.16 / 744.70 ms │ no change │
│ QQuery 19 │ 247.21 / 262.72 ±12.26 / 280.89 ms │ 249.35 / 268.43 ±28.13 / 323.63 ms │ no change │
│ QQuery 20 │  281.92 / 292.22 ±9.43 / 306.94 ms │ 271.39 / 284.41 ±12.61 / 306.62 ms │ no change │
│ QQuery 21 │  667.64 / 674.51 ±5.67 / 683.47 ms │  667.28 / 676.54 ±7.94 / 691.14 ms │ no change │
│ QQuery 22 │     61.14 / 65.17 ±4.27 / 73.44 ms │     60.93 / 67.25 ±8.02 / 82.86 ms │ no change │
└───────────┴────────────────────────────────────┴────────────────────────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                           ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                           │ 6807.66ms │
│ Total Time (test-ipc-not-sharing-buffers)   │ 6839.55ms │
│ Average Time (HEAD)                         │  309.44ms │
│ Average Time (test-ipc-not-sharing-buffers) │  310.89ms │
│ Queries Faster                              │         0 │
│ Queries Slower                              │         0 │
│ Queries with No Change                      │        22 │
│ Queries with Failure                        │         0 │
└─────────────────────────────────────────────┴───────────┘

Resource Usage

tpch10 — base (merge-base)

Metric Value
Wall time 35.0s
Peak memory 4.9 GiB
Avg memory 1.5 GiB
CPU user 344.9s
CPU sys 19.8s
Peak spill 0 B

tpch10 — branch

Metric Value
Wall time 35.0s
Peak memory 5.1 GiB
Avg memory 1.5 GiB
CPU user 344.4s
CPU sys 20.0s
Peak spill 0 B

File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details

Comparing HEAD and test-ipc-not-sharing-buffers
--------------------
Benchmark external_aggr.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query        ┃                               HEAD ┃       test-ipc-not-sharing-buffers ┃    Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Q1(64.0 MB)  │     51.89 / 56.05 ±2.93 / 60.82 ms │     50.46 / 55.02 ±4.48 / 63.12 ms │ no change │
│ Q1(32.0 MB)  │     49.00 / 51.21 ±1.49 / 53.07 ms │     48.87 / 50.72 ±1.77 / 53.93 ms │ no change │
│ Q1(16.0 MB)  │     50.55 / 53.04 ±1.40 / 54.80 ms │     51.83 / 53.59 ±1.09 / 54.69 ms │ no change │
│ Q2(512.0 MB) │ 269.51 / 291.71 ±17.13 / 321.63 ms │ 261.30 / 288.19 ±20.72 / 311.15 ms │ no change │
│ Q2(256.0 MB) │  245.17 / 256.88 ±6.43 / 262.66 ms │  247.32 / 255.35 ±6.11 / 265.93 ms │ no change │
│ Q2(128.0 MB) │  243.48 / 245.52 ±2.81 / 250.93 ms │  243.79 / 245.00 ±0.92 / 246.30 ms │ no change │
│ Q2(64.0 MB)  │ 241.00 / 250.70 ±10.88 / 271.78 ms │  244.91 / 245.79 ±0.51 / 246.46 ms │ no change │
│ Q2(32.0 MB)  │  298.30 / 304.09 ±3.18 / 308.05 ms │  302.83 / 310.68 ±7.12 / 321.20 ms │ no change │
└──────────────┴────────────────────────────────────┴────────────────────────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                           ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                           │ 1509.19ms │
│ Total Time (test-ipc-not-sharing-buffers)   │ 1504.34ms │
│ Average Time (HEAD)                         │  188.65ms │
│ Average Time (test-ipc-not-sharing-buffers) │  188.04ms │
│ Queries Faster                              │         0 │
│ Queries Slower                              │         0 │
│ Queries with No Change                      │         8 │
│ Queries with Failure                        │         0 │
└─────────────────────────────────────────────┴───────────┘

Resource Usage

external_aggr — base (merge-base)

Metric Value
Wall time 510.1s
Peak memory 473.0 MiB
Avg memory 9.7 MiB
CPU user 26.3s
CPU sys 3.6s
Peak spill 0 B

external_aggr — branch

Metric Value
Wall time 515.1s
Peak memory 479.3 MiB
Avg memory 8.8 MiB
CPU user 22.7s
CPU sys 2.9s
Peak spill 0 B

File an issue against this benchmark runner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change common Related to common crate datasource Changes to the datasource crate execution Related to the execution crate physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants