Skip to content

test: improve isnan function SQL test coverage#23754

Merged
Jefffrey merged 1 commit into
apache:mainfrom
2010YOUY01:codex/coverage-isnan
Jul 23, 2026
Merged

test: improve isnan function SQL test coverage#23754
Jefffrey merged 1 commit into
apache:mainfrom
2010YOUY01:codex/coverage-isnan

Conversation

@2010YOUY01

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

Codecov reports low test coverage for this function, so this PR adds more SLT tests for it.

The tests were AI-generated, and I manually verified that the results are correct.

See Codecov bot comment -> ☔ View full report in Codecov by Harness -> Indirect Changes for the updated test coverage.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added the sqllogictest SQL Logic Tests (.slt) label Jul 21, 2026
@codecov-commenter

codecov-commenter commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.72%. Comparing base (02a902c) to head (1a72cbc).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23754      +/-   ##
==========================================
+ Coverage   80.71%   80.72%   +0.01%     
==========================================
  Files        1089     1089              
  Lines      368293   368750     +457     
  Branches   368293   368750     +457     
==========================================
+ Hits       297250   297682     +432     
+ Misses      53332    53323       -9     
- Partials    17711    17745      +34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alamb
alamb added this pull request to the merge queue Jul 22, 2026
@alamb

alamb commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Thanks @2010YOUY01 and @nuno-faria -- this is great

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2026
@Jefffrey
Jefffrey added this pull request to the merge queue Jul 23, 2026
Merged via the queue into apache:main with commit 092ec9e Jul 23, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants