Skip to content

refactor(proto): migrate GlobalLimitExec and LocalLimitExec serde#23791

Open
buraksenn wants to merge 4 commits into
apache:mainfrom
buraksenn:buraksen/23502-proto-limits
Open

refactor(proto): migrate GlobalLimitExec and LocalLimitExec serde#23791
buraksenn wants to merge 4 commits into
apache:mainfrom
buraksenn:buraksen/23502-proto-limits

Conversation

@buraksenn

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Part of epic #23494. Moves GlobalLimitExec and LocalLimitExec protobuf serialization from central dispatch.

What changes are included in this PR?

Add new proto functions in physical plan and deprecate proto ones.

Are these changes tested?

Yes, existing round trip tests pass.

Are there any user-facing changes?

Existing methods are deprecated with no immediate API change.

@github-actions github-actions Bot added proto Related to proto crate physical-plan Changes to the physical-plan crate labels Jul 22, 2026
@github-actions

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion-physical-plan v54.1.0 (current)
       Built [  39.233s] (current)
     Parsing datafusion-physical-plan v54.1.0 (current)
      Parsed [   0.145s] (current)
    Building datafusion-physical-plan v54.1.0 (baseline)
       Built [  38.330s] (baseline)
     Parsing datafusion-physical-plan v54.1.0 (baseline)
      Parsed [   0.146s] (baseline)
    Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch)
     Checked [   0.574s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [  80.026s] datafusion-physical-plan
    Building datafusion-proto v54.1.0 (current)
       Built [  61.508s] (current)
     Parsing datafusion-proto v54.1.0 (current)
      Parsed [   0.019s] (current)
    Building datafusion-proto v54.1.0 (baseline)
       Built [  61.889s] (baseline)
     Parsing datafusion-proto v54.1.0 (baseline)
      Parsed [   0.020s] (baseline)
    Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch)
     Checked [   0.222s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip

--- failure trait_method_marked_deprecated: trait method #[deprecated] added ---

Description:
A trait method is now #[deprecated]. Downstream crates will get a compiler warning when using this method.
        ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_marked_deprecated.ron

Failed in:
  method try_into_global_limit_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:722
  method try_into_local_limit_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:722
  method try_from_global_limit_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:722
  method try_from_local_limit_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:722

     Summary semver requires new minor version: 0 major and 1 minor checks failed
    Finished [ 124.879s] datafusion-proto

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Jul 22, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.69%. Comparing base (5de7f1d) to head (a8d4e5f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
datafusion/proto/src/physical_plan/mod.rs 5.88% 32 Missing ⚠️
datafusion/physical-plan/src/limit.rs 92.85% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23791      +/-   ##
==========================================
- Coverage   80.71%   80.69%   -0.02%     
==========================================
  Files        1089     1089              
  Lines      368760   368803      +43     
  Branches   368760   368803      +43     
==========================================
- Hits       297647   297615      -32     
- Misses      53372    53439      +67     
- Partials    17741    17749       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change physical-plan Changes to the physical-plan crate proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proto: migrate GlobalLimitExec + LocalLimitExec

2 participants