refactor(proto): migrate GlobalLimitExec and LocalLimitExec serde#23791
Open
buraksenn wants to merge 4 commits into
Open
refactor(proto): migrate GlobalLimitExec and LocalLimitExec serde#23791buraksenn wants to merge 4 commits into
buraksenn wants to merge 4 commits into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23791 +/- ##
==========================================
- Coverage 80.71% 80.69% -0.02%
==========================================
Files 1089 1089
Lines 368760 368803 +43
Branches 368760 368803 +43
==========================================
- Hits 297647 297615 -32
- Misses 53372 53439 +67
- Partials 17741 17749 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Part of epic #23494. Moves
GlobalLimitExecandLocalLimitExecprotobuf serialization from central dispatch.What changes are included in this PR?
Add new proto functions in physical plan and deprecate proto ones.
Are these changes tested?
Yes, existing round trip tests pass.
Are there any user-facing changes?
Existing methods are deprecated with no immediate API change.