refactor(proto): migrate AsyncFuncExec to self-serializing proto#23825
Open
mattp5657 wants to merge 1 commit into
Open
refactor(proto): migrate AsyncFuncExec to self-serializing proto#23825mattp5657 wants to merge 1 commit into
mattp5657 wants to merge 1 commit into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23825 +/- ##
==========================================
- Coverage 80.72% 80.70% -0.02%
==========================================
Files 1089 1089
Lines 368911 368932 +21
Branches 368911 368932 +21
==========================================
- Hits 297785 297762 -23
- Misses 53374 53409 +35
- Partials 17752 17761 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23514. Part of #23494.
Migrate
AsyncFuncExecproto encode/decode into the plan itself viatry_to_proto/try_from_proto, removing its central-arm handling inphysical_plan/mod.rs.Rationale
datafusion-protocurrently downcastsAsyncFuncExecin the central encode match and rebuilds it inline on decode. #23495 introduced self-serializing hooks so each plan owns its own wire format. This movesAsyncFuncExeconto that pattern.Changes
try_to_proto/AsyncFuncExec::try_from_proto, wired into the decode dispatch#[deprecated]stubs, per existing conventionTesting
Existing
roundtrip_async_func_execintegration test now exercises the new hooks (old path deleted, so it's the only path left).cargo fmt+cargo clippy --all-targets --features proto -- -D warningsclean.User-facing changes
No