Add setter for TaskContext::task_id#23837
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23837 +/- ##
==========================================
- Coverage 80.75% 80.75% -0.01%
==========================================
Files 1089 1089
Lines 368809 368813 +4
Branches 368809 368813 +4
==========================================
- Hits 297837 297824 -13
- Misses 53217 53235 +18
+ Partials 17755 17754 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
I was just going through old issues. The issue logger's stated reason is correlating log messages. I didn't have any information to add myself beyond that since I don't really have a need for this myself. The request made sense to me since the field is already there but there's no convenient way to set it when you create the TaskContext via the SessionContext.. |
Which issue does this PR close?
Closes #22072
Rationale for this change
Without a way to set
TaskContext::task_idthe field is a bit pointless. This MR adds a way to set the field.This does not automatically make the field useful for correlation purposes (as hinted at by the linked issue) since it's not filled in anywhere yet, but at least the capability is already there.
Are these changes tested?
Not sure how to meaningfully test this
Are there any user-facing changes?
No