Skip to content

Add setter for TaskContext::task_id#23837

Merged
comphead merged 1 commit into
apache:mainfrom
pepijnve:issue_22072
Jul 23, 2026
Merged

Add setter for TaskContext::task_id#23837
comphead merged 1 commit into
apache:mainfrom
pepijnve:issue_22072

Conversation

@pepijnve

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #22072

Rationale for this change

Without a way to set TaskContext::task_id the field is a bit pointless. This MR adds a way to set the field.
This does not automatically make the field useful for correlation purposes (as hinted at by the linked issue) since it's not filled in anywhere yet, but at least the capability is already there.

Are these changes tested?

Not sure how to meaningfully test this

Are there any user-facing changes?

No

@github-actions github-actions Bot added the execution Related to the execution crate label Jul 23, 2026
@codecov-commenter

codecov-commenter commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.75%. Comparing base (1c8295c) to head (94f0cc8).

Files with missing lines Patch % Lines
datafusion/execution/src/task.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23837      +/-   ##
==========================================
- Coverage   80.75%   80.75%   -0.01%     
==========================================
  Files        1089     1089              
  Lines      368809   368813       +4     
  Branches   368809   368813       +4     
==========================================
- Hits       297837   297824      -13     
- Misses      53217    53235      +18     
+ Partials    17755    17754       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comphead comphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pepijnve makes sense to me
Probably going fwd it would be nice to document purposes when the user might need to populate the field, but the PR is good to go

@pepijnve

pepijnve commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @pepijnve makes sense to me Probably going fwd it would be nice to document purposes when the user might need to populate the field, but the PR is good to go

I was just going through old issues. The issue logger's stated reason is correlating log messages. I didn't have any information to add myself beyond that since I don't really have a need for this myself. The request made sense to me since the field is already there but there's no convenient way to set it when you create the TaskContext via the SessionContext..

@comphead
comphead added this pull request to the merge queue Jul 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 23, 2026
@comphead
comphead added this pull request to the merge queue Jul 23, 2026
Merged via the queue into apache:main with commit 4ea2060 Jul 23, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execution Related to the execution crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Meaningful Task ID

3 participants