Skip to content

refactor(proto): migrate HashJoinExec serde#23853

Merged
adriangb merged 2 commits into
apache:mainfrom
buraksenn:buraksen/23507-proto-hash-join
Jul 24, 2026
Merged

refactor(proto): migrate HashJoinExec serde#23853
adriangb merged 2 commits into
apache:mainfrom
buraksenn:buraksen/23507-proto-hash-join

Conversation

@buraksenn

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Part of epic #23494. Moves HashJoinExec protobuf serialization from central dispatch.

What changes are included in this PR?

Add protobuf serialization and deserialization to the HashJoinExec physical plan implementation and deprecate the corresponding central proto methods. The wire format remains unchanged.

Are these changes tested?

Yes, existing HashJoin round-trip tests cover this plan.

Are there any user-facing changes?

Existing methods are deprecated with no immediate API change.

@github-actions github-actions Bot added proto Related to proto crate physical-plan Changes to the physical-plan crate labels Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details
     Cloning apache/main
    Building datafusion-physical-plan v54.1.0 (current)
       Built [  30.019s] (current)
     Parsing datafusion-physical-plan v54.1.0 (current)
      Parsed [   0.116s] (current)
    Building datafusion-physical-plan v54.1.0 (baseline)
       Built [  30.293s] (baseline)
     Parsing datafusion-physical-plan v54.1.0 (baseline)
      Parsed [   0.118s] (baseline)
    Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch)
     Checked [   0.751s] 223 checks: 223 pass, 30 skip
     Summary no semver update required
    Finished [  62.954s] datafusion-physical-plan
    Building datafusion-proto v54.1.0 (current)
       Built [  48.066s] (current)
     Parsing datafusion-proto v54.1.0 (current)
      Parsed [   0.015s] (current)
    Building datafusion-proto v54.1.0 (baseline)
       Built [  48.586s] (baseline)
     Parsing datafusion-proto v54.1.0 (baseline)
      Parsed [   0.017s] (baseline)
    Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch)
     Checked [   0.254s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip

--- failure trait_method_marked_deprecated: trait method #[deprecated] added ---

Description:
A trait method is now #[deprecated]. Downstream crates will get a compiler warning when using this method.
        ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_marked_deprecated.ron

Failed in:
  method try_into_hash_join_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:714
  method try_from_hash_join_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:714

     Summary semver requires new minor version: 0 major and 1 minor checks failed
    Finished [  98.375s] datafusion-proto

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Jul 23, 2026
@codecov-commenter

codecov-commenter commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.69%. Comparing base (18b1e35) to head (0270737).

Files with missing lines Patch % Lines
...tafusion/physical-plan/src/joins/hash_join/exec.rs 79.84% 12 Missing and 14 partials ⚠️
datafusion/proto/src/physical_plan/mod.rs 7.14% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23853      +/-   ##
==========================================
- Coverage   80.70%   80.69%   -0.02%     
==========================================
  Files        1090     1090              
  Lines      370150   370116      -34     
  Branches   370150   370116      -34     
==========================================
- Hits       298746   298665      -81     
- Misses      53598    53647      +49     
+ Partials    17806    17804       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…hash-join

# Conflicts:
#	datafusion/proto/src/physical_plan/mod.rs

@adriangb adriangb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adriangb
adriangb added this pull request to the merge queue Jul 24, 2026
Merged via the queue into apache:main with commit 562f87d Jul 24, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto detected api change Auto detected API change physical-plan Changes to the physical-plan crate proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proto: migrate HashJoinExec

3 participants