fix(ffi): preserve TableProvider DML overrides - #23906
Open
Amogh-2404 wants to merge 4 commits into
Open
Conversation
Amogh-2404
force-pushed
the
fix/issue-22328-ffi-table-provider-defaults
branch
from
July 26, 2026 13:41
ca8af01 to
5568899
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23906 +/- ##
========================================
Coverage 80.65% 80.65%
========================================
Files 1093 1093
Lines 371619 371837 +218
Branches 371619 371837 +218
========================================
+ Hits 299730 299913 +183
- Misses 53993 54005 +12
- Partials 17896 17919 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #22328.
Rationale for this change
ForeignTableProviderinherits the default DML methods, so producer overrides are lost across the FFI boundary and writable tables appear read-only.What changes are included in this PR?
delete_from,update, andtruncatethroughFFI_TableProvider.Are these changes tested?
cargo test -p datafusion-ffi --features integration-testscargo clippy --all-targets --all-features -- -D warningsAre there any user-facing changes?
The FFI ABI changes. Foreign libraries must rebuild against the new DataFusion version.