Skip to content

chore: Squelch "unused code" warning - #23924

Merged
Jefffrey merged 2 commits into
apache:mainfrom
neilconway:neilc/chore-from-parts-unused
Jul 28, 2026
Merged

chore: Squelch "unused code" warning#23924
Jefffrey merged 2 commits into
apache:mainfrom
neilconway:neilc/chore-from-parts-unused

Conversation

@neilconway

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • N/A

Rationale for this change

$ cargo test -p datafusion-functions-aggregate
[...]
  warning: associated function `from_parts` is never used
     --> datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs:464:8
[...]

Fix this by appropriately gating the compilation of from_parts.

What changes are included in this PR?

  • Squelch unused code warning

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the physical-expr Changes to the physical-expr crates label Jul 27, 2026
@codecov-commenter

codecov-commenter commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.67%. Comparing base (9ab2068) to head (38f5aa8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23924      +/-   ##
==========================================
- Coverage   80.68%   80.67%   -0.01%     
==========================================
  Files        1095     1095              
  Lines      372458   372458              
  Branches   372458   372458              
==========================================
- Hits       300500   300486      -14     
- Misses      54032    54042      +10     
- Partials    17926    17930       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jefffrey
Jefffrey added this pull request to the merge queue Jul 28, 2026
@Jefffrey

Copy link
Copy Markdown
Contributor

thanks @neilconway

Merged via the queue into apache:main with commit daacd72 Jul 28, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants