fix: preserve the timezone in the schema when resolving output timezone - #23925
Draft
nevi-me wants to merge 1 commit into
Draft
fix: preserve the timezone in the schema when resolving output timezone#23925nevi-me wants to merge 1 commit into
nevi-me wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23925 +/- ##
==========================================
- Coverage 80.67% 80.67% -0.01%
==========================================
Files 1095 1095
Lines 372460 372519 +59
Branches 372460 372519 +59
==========================================
+ Hits 300495 300536 +41
- Misses 54040 54054 +14
- Partials 17925 17929 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
to_timestamp_*discards the timezone of already-timezone-aware inputs #23841.Rationale for this change
to_timestamp_millis (and the rest of the family) should not silently drop the timezone of an already-zoned input. Passing a Timestamp(_, Some("+05:00")) through the function should either:
What changes are included in this PR?
Restore the behaviour of preserving the input zone
Are these changes tested?
Are there any user-facing changes?