docs: Fixes incorrect type name in UserDefinedLogicalNode comment - #23992
Merged
neilconway merged 1 commit intoJul 30, 2026
Merged
Conversation
neilconway
approved these changes
Jul 30, 2026
neilconway
left a comment
neilconway
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix, @vikrantmehta123 !
neilconway
enabled auto-merge
July 30, 2026 11:12
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23992 +/- ##
==========================================
+ Coverage 80.75% 80.77% +0.01%
==========================================
Files 1096 1096
Lines 373588 373769 +181
Branches 373588 373769 +181
==========================================
+ Hits 301691 301894 +203
+ Misses 53896 53865 -31
- Partials 18001 18010 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The doc comment in
datafusion/expr/src/logical_plan/extension.rsincorrectly said it "derives UserDefinedLogicalNode toUserDefinedLogicalNode" ( It named the same type twice ). This PR fixes this trivial documentation.What changes are included in this PR?
A single line containing the documentation fix, which corrects the source trait name from
UserDefinedLogicalNodetoUserDefinedLogicalNodeCore.Are these changes tested?
No tests needed as this is a comment-only change.
Are there any user-facing changes?
No.