minor(fix): correct to_date results for formatted pre-epoch datetimes - #24049
Merged
kumarUjjawal merged 1 commit intoAug 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24049 +/- ##
==========================================
+ Coverage 80.84% 80.86% +0.01%
==========================================
Files 1096 1101 +5
Lines 373832 375446 +1614
Branches 373832 375446 +1614
==========================================
+ Hits 302240 303587 +1347
- Misses 53563 53767 +204
- Partials 18029 18092 +63 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Thank you @buraksenn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Formatted
to_dateinputs are parsed as milliseconds since the Unix epoch and then converted toDate32days. Integer division truncates toward zero, so negative sub-day timestamps are incorrectly mapped to day0instead of day-1.What changes are included in this PR?
Use Euclidean division when converting formatted timestamp milliseconds to days, preserving the correct date for timestamps before the Unix epoch.
Are these changes tested?
Yes new slt test for this case.
Are there any user-facing changes?
No API changes. Formatted pre-epoch datetimes now return the correct date.