perf: Concretely typed TopK StringHeap, and StringHashTable slot reuse - #24105
Draft
MassivePizza wants to merge 7 commits into
Draft
perf: Concretely typed TopK StringHeap, and StringHashTable slot reuse#24105MassivePizza wants to merge 7 commits into
MassivePizza wants to merge 7 commits into
Conversation
avoiding from(Vec) into drop.
MassivePizza
force-pushed
the
topk-mutable-borrow-slots
branch
from
August 12, 2026 20:08
6ed1b35 to
ddd9b71
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24105 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 1110 1110
Lines 386107 386110 +3
Branches 386107 386110 +3
=======================================
+ Hits 313313 313317 +4
+ Misses 54329 54328 -1
Partials 18465 18465 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Continuation of #23609.
Rationale for this change
Improve perf of TopK.
What changes are included in this PR?
Eliminate overhead of casting with
dyn Anyfor every String intopk::StringHeap.Rearrange
HashTableItem<ID>Option-ness to avoid unnecessary unwraps on lookups intopk::TopKHashTable.Rewrite inserts to take a borrowable type, delaying clones and allowing reuse of storage slots (mostly Strings).
Are these changes tested?
Should be covered by existing tests.
Making
IDanOption<ID>insideHashTableItemshould be fine, since the internalHashTablekeeps track of valid items (although this could be hard to verify properly). It runs with the assumption that "if everything needed an unwrap, nothing needs an unwrap".Are there any user-facing changes?
No.