bench: add standard window function cases to bounded_window - #24151
Open
neilconway wants to merge 1 commit into
Open
bench: add standard window function cases to bounded_window#24151neilconway wants to merge 1 commit into
neilconway wants to merge 1 commit into
Conversation
neilconway
force-pushed
the
neilc/bench-window-standard-fns
branch
from
August 6, 2026 22:03
4b6f383 to
2de376d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
BoundedWindowAggExecinLinearmode is slow for many-partitions #23982Rationale for this change
The
bounded_windowbenchmark only covered aggregate window expressions (countandsum). Window functions such asrow_number,rank,lag,lead, andnth_valuego through a different code path, for which we had no benchmark coverage.Add four new benchmark cases:
linear dense row_number 10000 partitions: per-visit fixed costs on partitions that receive rows in every batch.linear sparse row_number 32768 partitions: per-batch work on quiet partitions dominates.linear sparse lead 32768 partitions: a non-causal function, whose result for the last buffered row of a partition stays pending until that partition receives another row.linear dense rank 10000 partitions: an evaluator that compares ORDER BY values row by row.Also rename the existing case names to be consistent.
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.