fix: return error instead of panic when decoding ParquetScan/AvroScan without features - #24198
Open
nam2ee wants to merge 1 commit into
Open
fix: return error instead of panic when decoding ParquetScan/AvroScan without features#24198nam2ee wants to merge 1 commit into
nam2ee wants to merge 1 commit into
Conversation
… without features
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24198 +/- ##
==========================================
- Coverage 81.05% 81.04% -0.01%
==========================================
Files 1106 1106
Lines 382398 382398
Branches 382398 382398
==========================================
- Hits 309938 309914 -24
- Misses 54149 54168 +19
- Partials 18311 18316 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kumarUjjawal
approved these changes
Aug 9, 2026
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
Thank you @nam2ee
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Explained in #24197.
What changes are included in this PR?
I just replaced the three feature-gate
panic!s indatafusion/proto/src/physical_plan/mod.rswithnot_impl_err!, following the existingParquetSinkconvention in the same file. Also fixes "a Avro" to "an Avro" in the message.Are these changes tested?
Checked the same feature combinations as the
datafusion-proto featuresCI job and rancargo test -p datafusion-proto. Manually verified with a no-default-features build that decoding panicked before and returnsNotImplementedafter. No regression test added because the error path only exists in feature-disabled builds, which CI only runscargo checkon.Are there any user-facing changes?
No API changes.