bench: pwmj right semi/anti existence joins - #24458
Open
SubhamSinghal wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24458 +/- ##
==========================================
- Coverage 81.23% 81.23% -0.01%
==========================================
Files 1113 1113
Lines 392521 392521
Branches 392521 392521
==========================================
- Hits 318867 318860 -7
- Misses 54902 54903 +1
- Partials 18752 18758 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@SubhamSinghal Can you fix the clippy issues, please? |
Contributor
Author
|
resolved clippy error but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PiecewiseMergeJoinwork in Datafusion #17427. Companion to bench: pwmj left semi/anti join #24160, which added this benchmark for theLeftSemi/LeftAntihalf.Rationale for this change
RightSemi/RightAntirange joins plan asNestedLoopJoinExectoday, and the existence-joinbenchmark added in #24160 does not cover them, so there is no way to say what routing them
PiecewiseMergeJoinExecwould be worth — before or after such a change lands.This benchmark runs on either side of it: the
pwmj_enabledarm accepts whichever operator the build plans and prints it, so a run onmaintoday is a validNestedLoopJoinExecbaseline that a later build compares straight against.What changes are included in this PR?
Bench code only, all in
datafusion/core/benches/pwmj_semi_anti_sql.rs:RIGHT SEMI/RIGHT ANTIcases across the same three match regimes as the existing ones, written out as joins rather than reached throughEXISTS(a decorrelatedEXISTSgivesLeftSemi, and which side a nested-loop join marks is its own choice, so a subquery cannot pin these join types).bench_caserunner shared by every case, replacing the previous inline per-case plumbing, driven by aKindenum with one variant perJoinType. Adding the mark joins later is two more variants rather than a new code path.Are these changes tested?
The guards above are the tests
Are there any user-facing changes?
No. Benchmark code only.