fix: tree-style explain for memory table shows wrong row count - #24511
Merged
Conversation
2010YOUY01
commented
Aug 20, 2026
| arrow_cast(column4, 'FixedSizeList(3, Float64)') AS column4 | ||
| FROM arrays_distance_table | ||
| ; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Those small formatting changes are enforced by cargo test --test sqllogictests -- --complete
We can keep them here, and future auto-fixes won't need to change again.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24511 +/- ##
==========================================
- Coverage 81.27% 81.27% -0.01%
==========================================
Files 1116 1116
Lines 395017 395078 +61
Branches 395017 395078 +61
==========================================
+ Hits 321055 321101 +46
- Misses 55166 55179 +13
- Partials 18796 18798 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Dandandan
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
See reproducer in datafusion-cli, the
rows:1line in the explain is the wrong result, it should be total rows for the memory table (101)What changes are included in this PR?
fix the explain for row count
Are these changes tested?
sqllogictest
Are there any user-facing changes?