perf: use compact pruning for large string NOT IN lists - #24781
Open
kumarUjjawal wants to merge 1 commit into
Open
perf: use compact pruning for large string NOT IN lists#24781kumarUjjawal wants to merge 1 commit into
kumarUjjawal wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24781 +/- ##
==========================================
- Coverage 81.53% 81.53% -0.01%
==========================================
Files 1123 1123
Lines 406041 406218 +177
Branches 406041 406218 +177
==========================================
+ Hits 331049 331192 +143
- Misses 55631 55652 +21
- Partials 19361 19374 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
@sunchao would you be interested in reviewing @kumarUjjawal's work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
IN-list pruning excludesNOT INand NULL-containing lists #24711.Rationale for this change
Large string NOT IN lists create long expression chains for Parquet pruning. These expressions are expensive to build and evaluate.
What changes are included in this PR?
Use a compact sorted domain for large, non-null string NOT IN lists.
Preserve the existing behavior for lists containing NULL.
Add unit tests and Parquet row-group and page-pruning tests.
Add a mixed-container regression test.
Extend the existing benchmark and configuration documentation.
In a local benchmark with 1,024 values, construction was about 17 times faster and evaluation was about 27 times faster.
Are these changes tested?
Yes
Are there any user-facing changes?
No public API changes