perf: Optimize prefix-group processing in PartialSortExec - #24979
Open
lyne7-sc wants to merge 3 commits into
Open
perf: Optimize prefix-group processing in PartialSortExec#24979lyne7-sc wants to merge 3 commits into
PartialSortExec#24979lyne7-sc wants to merge 3 commits into
Conversation
PartialSortExec
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24979 +/- ##
==========================================
+ Coverage 81.64% 81.67% +0.03%
==========================================
Files 1123 1126 +3
Lines 410248 414772 +4524
Branches 410248 414772 +4524
==========================================
+ Hits 334940 338770 +3830
- Misses 55617 56082 +465
- Partials 19691 19920 +229 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
PartialSortStreamconcatenates each incoming batch with the buffered incomplete prefix before looking for a completed prefix boundary.When one prefix spans multiple batches, this repeatedly copies rows accumulated from earlier batches. When a batch contains multiple completed prefix groups, the completed region is also sorted using the full ordering even though the prefix ordering is already satisfied.
This adds unnecessary copying and sorting work, especially for wide batches and workloads containing multiple prefix groups per batch.
What changes are included in this PR?
RecordBatchslices instead of concatenating it with every incoming batch.What is the testing strategy for this PR?
The implementation is covered by the existing
PartialSortExecunit tests and the additional SQL logic test cases ingroup_by.slt.Are there any user-facing changes?
No. This is an internal performance improvement.
Benchmark