MINOR: Move ExprVisitable and exprlist_to_columns to datafusion-expr crate
#2538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 16, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- nice cleanup. Thank you @andygrove
korowa
pushed a commit
to korowa/arrow-datafusion
that referenced
this pull request
May 18, 2022
…xpr crate (apache#2538) * Move ExprVisitable to datafusion-expr crate * move more utility methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2345
Rationale for this change
ExprVisitableandexprlist_to_columnsare used by the SQL planner and also by the optimizer. They were in the core crate but can be moved to thedatafusion-exprcrate.What changes are included in this PR?
Move some code around. No functional changes.
Are there any user-facing changes?
Yes, this is an API change.