Create new datafusion-optimizer crate for logical optimizer rules
#2675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
andygrove
force-pushed
the
optimizer-crate
branch
from
15f1e75 to
99d2f20
Compare
andygrove
changed the title
datafusion-optimizer crate for logical optimizer rulesdatafusion-optimizer crate for logical optimizer rules
Member
Author
tustvold
approved these changes
Jun 2, 2022
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
This seems sensible to me, I think some code should be being moved instead of copied though
| @@ -0,0 +1,80 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
Contributor
There was a problem hiding this comment.
This appears to be duplicating the file from core, instead of moving it. Is this intentional?
Member
Author
There was a problem hiding this comment.
@tustvold Thanks. I hadn't realized that this was only used by the optimizer test. I have now moved this instead,
| pub mod user_defined; | ||
|
|
||
| /// some tests share a common table with different names | ||
| pub fn test_table_scan_with_name(name: &str) -> Result<LogicalPlan> { |
Contributor
There was a problem hiding this comment.
These functions don't appear to be being used by any tests that haven't also been moved, so perhaps they could be removed from core also?
Member
Author
There was a problem hiding this comment.
I have removed this from core now
alamb
reviewed
Jun 2, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
LGTM -- thanks @andygrove and @tustvold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2599
Rationale for this change
As a user of DataFusion for SQL query planning, I would like to be able to use the logical plan optimizer rules without depending on the full datafusion crate containing the execution engine.
What changes are included in this PR?
datafusion-optimizercratesimplify_expressionsto the new crate (see Logical optimizer rule "simplify expressions" should not depend on the core datafusion crate #2535 for the reason this one rule cannot yet be moved)Are there any user-facing changes?
I added public re-exports for now to maintain API compatibility but there is a new crate so technically this is probably still an API change.
Does this PR break compatibility with Ballista?
No