fix: union schema fix #2688
Merged
fix: union schema fix #2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
logical-expr
Member
|
@gandronchik We have a PR template in place that prompts for information that is helpful for reviewers. Could you fill out the description please otherwise I have no idea what this PR is for or what issue it is closing. |
andygrove
reviewed
Jun 3, 2022
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
The code changes look reasonable. I will review again once the PR description is updated.
Contributor
|
Changing to draft so it is easy to see it has pending changes |
waynexia
pushed a commit
to waynexia/arrow-datafusion
that referenced
this pull request
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Not exists
Rationale for this change
For now, Union Inputs Projections can have different schemas (because of forcing changing alias name to "column{}"). In case you want to recreate Union from these Inputs, you can catch an exception, because of different schemas.
What changes are included in this PR?
Are there any user-facing changes?
No
Hello! I am an employee of Cube.js. We do post-processing of logical plan in our project and in some cases, we unwrap Union and build it back. And we catch an exception because of wrong schemas.