Skip to content

Conversation

@andygrove
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

  • In preparation for the 9.0.0 release I thought it would be useful to add an example to the new datafusion-sql crate so that it is easier for users to get started. It also documents our public API to some degree.

What changes are included in this PR?

  • New example
  • Update CI to run the example
  • Updated README

Are there any user-facing changes?

No

@github-actions github-actions bot added logical-expr Logical plan and expressions sql SQL Planner labels Jun 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2693 (02bf992) into master (3c1c188) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2693      +/-   ##
==========================================
- Coverage   84.70%   84.70%   -0.01%     
==========================================
  Files         268      268              
  Lines       47059    47060       +1     
==========================================
  Hits        39861    39861              
- Misses       7198     7199       +1     
Impacted Files Coverage Δ
datafusion/expr/src/logical_plan/builder.rs 91.94% <0.00%> (-0.18%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 67.63% <0.00%> (-0.27%) ⬇️
datafusion/optimizer/src/utils.rs 32.79% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1c188...02bf992. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👌

@andygrove andygrove merged commit 6396ff6 into apache:master Jun 4, 2022
@andygrove andygrove deleted the sql-example branch June 4, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants