Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Jun 5, 2022

Which issue does this PR close?

Part of #2683

Rationale for this change

The core/logical_plan module is now redundant and mostly consists of re-exports. There were two items remaining in this module that are not referenced from logical plans and should not be in this module. These items are DefaultTableSource and FunctionRegistry.

What changes are included in this PR?

  • Move DefaultTableSource to datasource module
  • Move FunctionRegistry to core/execution module

Are there any user-facing changes?

No. I added public re-exports.

@github-actions github-actions bot added the core Core DataFusion crate label Jun 5, 2022
@andygrove andygrove changed the title MINOR: Move DefaultTableSource to datasource module Move DefaultTableSource to datasource module Jun 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2022

Codecov Report

Merging #2701 (7d350ac) into master (9306534) will increase coverage by 0.00%.
The diff coverage is 84.61%.

@@           Coverage Diff           @@
##           master    #2701   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         270      271    +1     
  Lines       46919    46919           
=======================================
+ Hits        39724    39725    +1     
+ Misses       7195     7194    -1     
Impacted Files Coverage Δ
datafusion/core/src/datasource/mod.rs 93.93% <ø> (ø)
datafusion/core/src/logical_plan/plan.rs 94.82% <ø> (+1.02%) ⬆️
datafusion/core/src/physical_plan/planner.rs 77.51% <ø> (ø)
...fusion/core/src/datasource/default_table_source.rs 84.61% <84.61%> (ø)
datafusion/optimizer/src/utils.rs 31.72% <0.00%> (-1.08%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 68.73% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9306534...7d350ac. Read the comment docs.

@andygrove andygrove changed the title Move DefaultTableSource to datasource module Move remaining code out of legacy core/logical_plan module Jun 6, 2022
@andygrove andygrove self-assigned this Jun 6, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @andygrove

@alamb alamb merged commit 352f8b2 into apache:master Jun 6, 2022
@andygrove andygrove deleted the move-default-table-source branch January 27, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants