MINOR: Remove Offset struct #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
approved these changes
Jun 14, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Nice find -- thanks @andygrove
cc @ming535
waynexia
pushed a commit
to waynexia/arrow-datafusion
that referenced
this pull request
Jun 20, 2022
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 30, 2022
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 31, 2022
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
PR #2694 removed
LogicalPlan::Offsetbut did not remove the correspondingOffsetstruct.What changes are included in this PR?
Remove
OffsetstructAre there any user-facing changes?
Yes, removes a struct that was part of our public API.