MINOR: re-export sqlparser from datafusion-sql crate #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdye64
approved these changes
Jun 23, 2022
Contributor
There was a problem hiding this comment.
This is great. No more importing sqlparser in my projects own Cargo.toml and having random version mismatch issues when things change. Thanks @andygrove!
Codecov Report
@@ Coverage Diff @@
## master #2779 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 272 272
Lines 48073 48073
=======================================
Hits 40937 40937
Misses 7136 7136
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Users of datafusion-sql often run into confusing Rust errors when updating the datafusion-sql version and not using the correct sqlparser version.
What changes are included in this PR?
Re-export sqlparser so datafusion-sql users do not need to explicitly add it as a dependency.
Are there any user-facing changes?
No