Improve readability of table scan projections in query plans (remove Some and None)
#2789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-readability-merged # Conflicts: # datafusion/core/src/logical_plan/plan.rs # datafusion/core/src/optimizer/limit_push_down.rs # datafusion/core/tests/custom_sources.rs # datafusion/core/tests/sql/avro.rs # datafusion/core/tests/sql/explain_analyze.rs # datafusion/core/tests/sql/json.rs # datafusion/core/tests/sql/projection.rs # datafusion/core/tests/sql/udf.rs # datafusion/core/tests/user_defined_plan.rs # datafusion/expr/src/logical_plan/builder.rs # datafusion/expr/src/logical_plan/plan.rs # datafusion/optimizer/src/filter_push_down.rs # datafusion/optimizer/src/projection_push_down.rs # datafusion/optimizer/src/single_distinct_to_groupby.rs # datafusion/sql/src/planner.rs
github-actions
bot
added
core
Contributor
Author
|
@andygrove my concern however the output like Afaik Projection here is query projection(selected by user output), and TableScan projection is what needs to be fetched from the table to make query work. Since both of it named as projection won't be that confusing? |
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #2789 +/- ##
==========================================
- Coverage 85.14% 85.11% -0.04%
==========================================
Files 273 273
Lines 48248 48241 -7
==========================================
- Hits 41079 41058 -21
- Misses 7169 7183 +14
Continue to review full report at Codecov.
|
Contributor
Author
|
@andygrove please check this |
alamb
changed the title
Some and None)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2697 .
Rationale for this change
Improve readability for Table scans. Provide column name instead of column index.
TableScan a projection=[col1,col2]instead ofTableScan a projection=Some([col1,col2])What changes are included in this PR?
Are there any user-facing changes?