Skip to content

Conversation

@kmitchener
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Learning the project, the code, the repo -- the less to wade through, the better. Better to clean up files that aren't used.

What changes are included in this PR?

I'm fairly confident none of these files are used. No references in the project and latest updates are usually quite old. I believe they're leftovers from some previous migration.

Are there any user-facing changes?

No

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #2863 (0f82a8c) into master (a2da720) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2863   +/-   ##
=======================================
  Coverage   85.24%   85.25%           
=======================================
  Files         275      275           
  Lines       49002    49001    -1     
=======================================
+ Hits        41773    41776    +3     
+ Misses       7229     7225    -4     
Impacted Files Coverage Δ
datafusion/core/src/execution/memory_manager.rs 69.95% <0.00%> (-0.31%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 74.70% <0.00%> (+0.39%) ⬆️
datafusion/sql/src/utils.rs 51.95% <0.00%> (+0.40%) ⬆️
datafusion/core/src/physical_plan/metrics/value.rs 87.43% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2da720...0f82a8c. Read the comment docs.

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmitchener

@andygrove andygrove merged commit a19e1b8 into apache:master Jul 10, 2022
@kmitchener kmitchener deleted the remove-unneeded-files branch July 11, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants