Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 8, 2022

Which issue does this PR close?

N/A

Rationale for this change

Keep datafusion-cli packages up to date

What changes are included in this PR?

  1. Check in the results of running cargo update in the datafusion-cli directory

Are there any user-facing changes?

No

@alamb alamb marked this pull request as ready for review August 8, 2022 12:34
@andygrove
Copy link
Member

I assume this is needed because this project is not part of the workspace? Should we consider making it part of the workspace again? This is what we did recently in the Ballista project, in apache/datafusion-ballista#89

@codecov-commenter
Copy link

Codecov Report

Merging #3075 (cd66933) into master (6e6f3bf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head cd66933 differs from pull request most recent head 4ba1040. Consider uploading reports for the commit 4ba1040 to get more accurate results

@@            Coverage Diff             @@
##           master    #3075      +/-   ##
==========================================
+ Coverage   85.87%   85.88%   +0.01%     
==========================================
  Files         289      289              
  Lines       51941    51953      +12     
==========================================
+ Hits        44604    44620      +16     
+ Misses       7337     7333       -4     
Impacted Files Coverage Δ
datafusion/core/tests/dataframe_functions.rs 100.00% <100.00%> (ø)
datafusion/expr/src/expr_fn.rs 90.80% <100.00%> (+0.10%) ⬆️
...usion/physical-expr/src/aggregate/approx_median.rs 100.00% <100.00%> (+36.36%) ⬆️
datafusion/physical-expr/src/aggregate/build_in.rs 89.92% <100.00%> (ø)
datafusion/sql/src/planner.rs 82.00% <100.00%> (-0.02%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.60% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xudong963
Copy link
Member

Should we consider making it part of the workspace again?

Make sense

@andygrove
Copy link
Member

I filed https://github.com/apache/arrow-datafusion/issues/3077t to discuss adding the cli back to the workspace

@andygrove andygrove merged commit c95bb74 into apache:master Aug 8, 2022
@ursabot
Copy link

ursabot commented Aug 8, 2022

Benchmark runs are scheduled for baseline = 88f6548 and contender = c95bb74. c95bb74 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/update_datafusion_cli branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants